> On April 7, 2015, 1:50 p.m., Lukáš Tinkl wrote: > > Modules/energy/kcm.cpp, line 65 > > <https://git.reviewboard.kde.org/r/123282/diff/1/?file=360359#file360359line65> > > > > No need to make your name translatable :p
there's a whole argument on a patch to kglobalaccel about how author names do need to be translated. See the thread on https://git.reviewboard.kde.org/r/122680/ underneaths Aleix's review. I'm not saying you're wrong, but either you or luigi must be. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78622 ----------------------------------------------------------- On April 7, 2015, 1:37 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123282/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 1:37 p.m.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > I assume everyone knows by now. > > > Diffs > ----- > > CMakeLists.txt 139a49e > Modules/CMakeLists.txt 37a1faf > Modules/energy/CMakeLists.txt PRE-CREATION > Modules/energy/Messages.sh PRE-CREATION > Modules/energy/batterymodel.cpp PRE-CREATION > Modules/energy/config-kcm.h.cmake PRE-CREATION > Modules/energy/kcm.cpp PRE-CREATION > Modules/energy/kcm_energyinfo.desktop PRE-CREATION > Modules/energy/package/contents/ui/Graph.qml PRE-CREATION > Modules/energy/package/contents/ui/main.qml PRE-CREATION > Modules/energy/package/metadata.desktop PRE-CREATION > Modules/energy/statisticsprovider.h PRE-CREATION > Modules/energy/statisticsprovider.cpp PRE-CREATION > Modules/energy/wakeupmodel.h PRE-CREATION > Modules/energy/wakeupmodel.cpp PRE-CREATION > ToolTips/ktooltipwindow_p.h 0813e6a > ToolTips/ktooltipwindow_p.h 0813e6a > infocenter.cpp 1ebbf71 > kcmcontainer.cpp c76ac65 > sidepanel.cpp f30ef4b > > Diff: https://git.reviewboard.kde.org/r/123282/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
