----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78620 -----------------------------------------------------------
Ship it! cool, modulo just few small issues CMakeLists.txt (line 15) <https://git.reviewboard.kde.org/r/123282/#comment53784> QuickWidgets shouldn't be needed CMakeLists.txt (line 35) <https://git.reviewboard.kde.org/r/123282/#comment53792> Plasma/PlasmaQuick shouldn't be needed anymore Modules/energy/kcm.cpp (line 41) <https://git.reviewboard.kde.org/r/123282/#comment53790> shouldn't be needed anymore Modules/energy/package/contents/ui/main.qml (line 297) <https://git.reviewboard.kde.org/r/123282/#comment53787> I'm fine it stays as is for now, if just the color is taken from a Palette Modules/energy/package/metadata.desktop (line 15) <https://git.reviewboard.kde.org/r/123282/#comment53785> KPackage/GenericQml - Marco Martin On April 7, 2015, 1:37 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123282/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 1:37 p.m.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > I assume everyone knows by now. > > > Diffs > ----- > > CMakeLists.txt 139a49e > Modules/CMakeLists.txt 37a1faf > Modules/energy/CMakeLists.txt PRE-CREATION > Modules/energy/Messages.sh PRE-CREATION > Modules/energy/batterymodel.cpp PRE-CREATION > Modules/energy/config-kcm.h.cmake PRE-CREATION > Modules/energy/kcm.cpp PRE-CREATION > Modules/energy/kcm_energyinfo.desktop PRE-CREATION > Modules/energy/package/contents/ui/Graph.qml PRE-CREATION > Modules/energy/package/contents/ui/main.qml PRE-CREATION > Modules/energy/package/metadata.desktop PRE-CREATION > Modules/energy/statisticsprovider.h PRE-CREATION > Modules/energy/statisticsprovider.cpp PRE-CREATION > Modules/energy/wakeupmodel.h PRE-CREATION > Modules/energy/wakeupmodel.cpp PRE-CREATION > ToolTips/ktooltipwindow_p.h 0813e6a > ToolTips/ktooltipwindow_p.h 0813e6a > infocenter.cpp 1ebbf71 > kcmcontainer.cpp c76ac65 > sidepanel.cpp f30ef4b > > Diff: https://git.reviewboard.kde.org/r/123282/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
