> On April 7, 2015, 1:45 nachm., Aleix Pol Gonzalez wrote: > > kcmcontainer.cpp, line 62 > > <https://git.reviewboard.kde.org/r/123282/diff/1/?file=360371#file360371line62> > > > > unrelated?
Ah yeah, that is to make the headings in KInfoCenter match the new KTitleWidget style, should go in separately > On April 7, 2015, 1:45 nachm., Aleix Pol Gonzalez wrote: > > Modules/energy/package/contents/ui/main.qml, line 384 > > <https://git.reviewboard.kde.org/r/123282/diff/1/?file=360362#file360362line384> > > > > What do we need to have there? That's a separator line. However with Qt high dpi stuff we could probably hardcode 1px then, or use Screen.something magic > On April 7, 2015, 1:45 nachm., Aleix Pol Gonzalez wrote: > > Modules/energy/statisticsprovider.cpp, line 183 > > <https://git.reviewboard.kde.org/r/123282/diff/1/?file=360365#file360365line183> > > > > Looks quite big for a lambda, make it a method? I prefer having async DBus stuff in one place as if it were sync. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78621 ----------------------------------------------------------- On April 7, 2015, 1:37 nachm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123282/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 1:37 nachm.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > I assume everyone knows by now. > > > Diffs > ----- > > CMakeLists.txt 139a49e > Modules/CMakeLists.txt 37a1faf > Modules/energy/CMakeLists.txt PRE-CREATION > Modules/energy/Messages.sh PRE-CREATION > Modules/energy/batterymodel.cpp PRE-CREATION > Modules/energy/config-kcm.h.cmake PRE-CREATION > Modules/energy/kcm.cpp PRE-CREATION > Modules/energy/kcm_energyinfo.desktop PRE-CREATION > Modules/energy/package/contents/ui/Graph.qml PRE-CREATION > Modules/energy/package/contents/ui/main.qml PRE-CREATION > Modules/energy/package/metadata.desktop PRE-CREATION > Modules/energy/statisticsprovider.h PRE-CREATION > Modules/energy/statisticsprovider.cpp PRE-CREATION > Modules/energy/wakeupmodel.h PRE-CREATION > Modules/energy/wakeupmodel.cpp PRE-CREATION > ToolTips/ktooltipwindow_p.h 0813e6a > ToolTips/ktooltipwindow_p.h 0813e6a > infocenter.cpp 1ebbf71 > kcmcontainer.cpp c76ac65 > sidepanel.cpp f30ef4b > > Diff: https://git.reviewboard.kde.org/r/123282/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
