> On Nov. 11, 2014, 6:30 nachm., Martin Klapetek wrote: > > dataengines/notifications/notificationsengine.cpp, line 233 > > <https://git.reviewboard.kde.org/r/121105/diff/2/?file=327770#file327770line233> > > > > Given the bool is the result of the file containing "Event/...", the > > key here should be a combination of appRealName + the event name. > > > > Otherwise one notification with "configurable == bool" will make it > > inherently true for all notifications of the given app (or inherently > > false).
I don't get that. It just looks whether there are *any* Event/s in the file for the given application. If the given application does not have notifications, how could that change? - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121105/#review70246 ----------------------------------------------------------- On Nov. 11, 2014, 5:50 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121105/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 5:50 nachm.) > > > Review request for Plasma, Emmanuel Pescosta, Eike Hein, and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > This patch makes notifications only show the configure button if the > application actually has configurable notifications, adapted from > KNotifyEventList::fill(). > > > Diffs > ----- > > dataengines/notifications/notificationsengine.h 40155f2 > dataengines/notifications/notificationsengine.cpp 06233e9 > > Diff: https://git.reviewboard.kde.org/r/121105/diff/ > > > Testing > ------- > > Plasmashell's undo notification and NM notifications still have working > configure whereas KMail does not (the dialog was empty previously) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
