----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121105/#review70241 -----------------------------------------------------------
It's good in principle, but I'd like the results to be cached, doing this for every single notification seems a bit too much :) - Martin Klapetek On Nov. 11, 2014, 6:22 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121105/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 6:22 p.m.) > > > Review request for Plasma, Eike Hein and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > This patch makes notifications only show the configure button if the > application actually has configurable notifications, adapted from > KNotifyEventList::fill(). > > > Diffs > ----- > > dataengines/notifications/notificationsengine.cpp 06233e9 > > Diff: https://git.reviewboard.kde.org/r/121105/diff/ > > > Testing > ------- > > Plasmashell's undo notification and NM notifications still have working > configure whereas KMail does not (the dialog was empty previously) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
