> On April 29, 2014, 5:26 a.m., Kevin Ottens wrote: > > Wouldn't making the examples work without installation been a better fix? > > > > As a sidenote, I wonder why the frameworks group wasn't added to this > > review, are we missing some bit of config somewhere? I found it thanks to > > kde-commits. > > Marco Martin wrote: > should be possible for plasmoids. > for dataengines i don't think so, since are plugins loaded with kservice > (at least if there isn't a way that i didn't know)
btw, I added kdeframeworks group in the default groups in .reviewboardrc, so those done by script should be fine. (please remember it for those done manually too ;) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117814/#review56817 ----------------------------------------------------------- On April 28, 2014, 5:35 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117814/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 5:35 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Make examples optional (default to off) > > > Most users won't want to have tech demos on their real system. > > > Diffs > ----- > > CMakeLists.txt bc5d6d0 > > Diff: https://git.reviewboard.kde.org/r/117814/diff/ > > > Testing > ------- > > Build both variants editing flag with CCMake > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
