> On April 28, 2014, 6:44 a.m., Michael Palimaka wrote: > > I wonder if it would be useful to make the option part of ECM, so we could > > propagate this to other frameworks too keeping it consistent.
Personally, I don't think so. It's only the one line, and I want to customise the message. Plasma's usage is also a bit different from others; for kwidgetaddons (for example) wouldn't need to actually install the examples as everything can be run and seen from the build folder. In our case we need to install it for it to work. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117814/#review56705 ----------------------------------------------------------- On April 28, 2014, 12:39 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117814/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 12:39 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Make examples optional (default to off) > > > Most users won't want to have tech demos on their real system. > > > Diffs > ----- > > CMakeLists.txt bc5d6d0 > > Diff: https://git.reviewboard.kde.org/r/117814/diff/ > > > Testing > ------- > > Build both variants editing flag with CCMake > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
