----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53040 -----------------------------------------------------------
browsingbackends/localfiles/localfilesabstractbackend.cpp <https://git.reviewboard.kde.org/r/116554/#comment37339> const int in shells/newshell/package/contents/ui/mediacenter.qml <https://git.reviewboard.kde.org/r/116554/#comment37338> now that you are loading the playlist in init(), this call in play() is no longer needed. Remove it as well (and do confirm that files passed through command line still work) - Shantanu Tushar On March 16, 2014, 10:29 a.m., Harshit Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116554/ > ----------------------------------------------------------- > > (Updated March 16, 2014, 10:29 a.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Referring to Bug #331040 The functionality of the media starting to play on > the press of the "Play All" button has been implemented. > It has been noted and implemented that the media doesn't start over when new > songs/videos are added to an existing playlist. > > > Diffs > ----- > > browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 > shells/newshell/package/contents/ui/mediacenter.qml bac33c2 > > Diff: https://git.reviewboard.kde.org/r/116554/diff/ > > > Testing > ------- > > The testing has been done through various test scenarios. > > > Thanks, > > Harshit Agarwal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
