> On March 15, 2014, 7:44 p.m., Shantanu Tushar wrote: > > browsingbackends/localfiles/localfilesabstractbackend.cpp, line 169 > > <https://git.reviewboard.kde.org/r/116554/diff/2/?file=254194#file254194line169> > > > > 0 won't work when there are already some itmes in the playlist before > > addAllSongsToPlaylist is called. > > Harshit Agarwal wrote: > As discussed, it's working fine, I tested it such: > 1. Empty playlist, press PlayAll, songs get populated to the playlist, > and the first one starts playing. > 2. With the playlist having songs, pressed PlayAll for a different list. > The songs get pushed to the playlist, and the current song plays without any > interrupt. > 3. With no song playing, pressed PlayAll in a third folder, the songs > again get pushed to the playlist, and the playback starts from the top of the > playlist. (This behaviour is correct, right?)
#2 and #3 both should play the first song of the *new* song list that the user has added. So if there were 5 songs already and you added 10 more songs, 6th song should start playing. - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53000 ----------------------------------------------------------- On March 15, 2014, 6:21 p.m., Harshit Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116554/ > ----------------------------------------------------------- > > (Updated March 15, 2014, 6:21 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Referring to Bug #331040 The functionality of the media starting to play on > the press of the "Play All" button has been implemented. > It has been noted and implemented that the media doesn't start over when new > songs/videos are added to an existing playlist. > > > Diffs > ----- > > browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 > shells/newshell/package/contents/ui/mediacenter.qml 714e561 > > Diff: https://git.reviewboard.kde.org/r/116554/diff/ > > > Testing > ------- > > The testing has been done through various test scenarios. > > > Thanks, > > Harshit Agarwal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
