----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108224/#review24788 -----------------------------------------------------------
I don't like having a link dependency on plasmagenericshell. If that is supposed to be used, then it needs to go to the workspaces libs. I also think that this approach just doesn't scale. We use Plasma styled dialogs for more things and I don't want to have to use this approach everywhere and not all of them are C++ based. Furthermore in case of KWin it's a little bit stupid to set an X11 property for the shadows on a KWin internal window. I will look into the whole thing. I think especially the tabbox has some old code still around which might not be needed any more. kwin/CMakeLists.txt <http://git.reviewboard.kde.org/r/108224/#comment19047> careful with your remove whitespaces on save. I think I should push an update removing them... - Martin Gräßlin On Jan. 6, 2013, 6:55 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108224/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2013, 6:55 a.m.) > > > Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin. > > > Description > ------- > > use the same technique for krunner and some plasma to brought back tabbox > shadow. > > > Diffs > ----- > > kwin/CMakeLists.txt 62e9964 > kwin/kcmkwin/kwintabbox/CMakeLists.txt 72a6b72 > kwin/tabbox/declarative.h e36e67b > kwin/tabbox/declarative.cpp 3bdcfac > powerdevil/daemon/brightnessosdwidget.h ef08903 > powerdevil/daemon/brightnessosdwidget.cpp e4cf80a > > Diff: http://git.reviewboard.kde.org/r/108224/diff/ > > > Testing > ------- > > compiles, no problem. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
