----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review9006 -----------------------------------------------------------
Ship it! looks good except for one small issue (see below), but is generally ready to go in. as this includes a new string, this needs to wait until 4.9 development opens up (should happen early in january). plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/103393/#comment7468> just realized one more issue ... if the m_url is set twice in a row to a non-local file, then it will connect to this signal multiple times. this is easily controlled, however, by adding Qt::UniqueConnection to the parameters passed to connect. - Aaron J. Seigo On Dec. 16, 2011, 6:20 a.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103393/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2011, 6:20 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Adding patch for the TODO, mentioned in the folderview.cpp file. This patch > looks whether the url is local or remote. If its remote then checks for the > network status of the host machine. If the host machine is not connected to > the network then returns. > > > Diffs > ----- > > plasma/applets/folderview/folderview.h 4896f07 > plasma/applets/folderview/folderview.cpp 43d0511 > > Diff: http://git.reviewboard.kde.org/r/103393/diff/diff > > > Testing > ------- > > Tested by removing the host from the network and by adding the host to the > network. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
