----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8987 -----------------------------------------------------------
plasma/applets/folderview/folderview.cpp <http://git.reviewboard.kde.org/r/103393/#comment7460> this much be before the if on line 408 otherwise the return statement will prevent this connection from being made, defeating the purpose of this :) also, Solid::Networking::shouldConnect() should just be shouldConnect() - Aaron J. Seigo On Dec. 15, 2011, 3:16 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103393/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2011, 3:16 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Adding patch for the TODO, mentioned in the folderview.cpp file. This patch > looks whether the url is local or remote. If its remote then checks for the > network status of the host machine. If the host machine is not connected to > the network then returns. > > > Diffs > ----- > > plasma/applets/folderview/folderview.h 4896f07 > plasma/applets/folderview/folderview.cpp 43d0511 > > Diff: http://git.reviewboard.kde.org/r/103393/diff/diff > > > Testing > ------- > > Tested by removing the host from the network and by adding the host to the > network. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
