> On Dec. 12, 2011, 3:45 p.m., Aaron J. Seigo wrote:
> > plasma/applets/folderview/folderview.cpp, lines 409-413
> > <http://git.reviewboard.kde.org/r/103393/diff/1/?file=43162#file43162line409>
> >
> > this needs to be indented properly.
> >
> > also, instead of a knotification, which will appear somewhere
> > unrelated, try using the setMessage method that comes with Plasma::Applet
I hope you are pointing towards, showMessage. I couldn't find the setMessage in
Plasma::Applet. Is it ok to have:
Plasma::Applet::showMessage(KIcon("dialog-error"),networkStatus,Plasma::ButtonOk)
if you meant towards showMessage?
- Sujith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103393/#review8892
-----------------------------------------------------------
On Dec. 12, 2011, 3:40 p.m., Sujith Haridasan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103393/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2011, 3:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Adding patch for the TODO, mentioned in the folderview.cpp file. This patch
> looks whether the url is local or remote. If its remote then checks for the
> network status of the host machine. If the host machine is not connected to
> the network then returns.
>
>
> Diffs
> -----
>
> plasma/applets/folderview/folderview.cpp 43d0511
>
> Diff: http://git.reviewboard.kde.org/r/103393/diff/diff
>
>
> Testing
> -------
>
> Tested by removing the host from the network and by adding the host to the
> network.
>
>
> Thanks,
>
> Sujith Haridasan
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
