meven added inline comments. INLINE COMMENTS
> ervin wrote in autostartmodel.h:52 > Weeell... knowing about Qt::DisplayRole is kind of prerequisite to making > your own model. :-) As you want. IMO this is not a good pattern to expect reviewers to have any previous knowledge about enum values, especially for new contributors (I was concerned by this when I started reading QAbstractModel implementations) Better to teach them those values by making things explicit. It also helps when using an IDE for discoverability. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26934 To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
