meven added inline comments.
INLINE COMMENTS
> broulik wrote in autostart.cpp:210
> You probably want to loop
>
> for (int i = first; i <= last; ++i) {
?
> broulik wrote in autostart.cpp:182
> In preparation for a move to QML, can we please not `exec()`
You mean I should use open/finished right ?
> broulik wrote in autostart.cpp:231
> Don't always ignore those ranges, we want to handle this model stuff properly
?
> broulik wrote in autostart.cpp:241
> `qobject_cast`
Can't use it here: QTreeWidgetItem does not inherit QObject.
> broulik wrote in autostartmodel.h:52
> Why not just use `Qt::DisplayRole`?
Not sure what you mean.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26934
To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
