ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> broulik wrote in autostart.cpp:182
> Yes.
> It then also needs to set a transient parent and window modality manual I
> think
Yes, otherwise you wouldn't get a modal dialog.
> meven wrote in autostart.cpp:231
> ?
Yes, similar situation to rowInserted here.
> broulik wrote in autostart.cpp:241
> Ok
Yes, it used to also inherit QObject (which wasn't a great idea) but not
anymore.
> autostart.cpp:260
> + if (desktopItem)
> {
> + const QModelIndex index = indexFromWidget(ent);
This curly brace needs to be on the previous line.
> broulik wrote in autostart.cpp:102
> Coding style:
>
> if (enabled) {
> ...
> }
I think Kai's point was also that the curly braces are required for the if and
the else
> broulik wrote in autostart.cpp:210
> rows inserted gives you a range of [first,last] which was added
Good point, this still needs to be addressed.
> broulik wrote in autostart.h:64
> Capitalize `Changed`
Still needs being addressed
> autostartmodel.cpp:177
> + // add scripts, skips first value of listPath
> + // .config/autostart that is not compatible with scripts
> + for (int i = 1; i < listPath().length(); i++) {
Makes me realize: are we sure it will always be the first entry? I'm not sure
we can guarantee that over time.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26934
To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
