ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> DeviceAutomounterKCM.cpp:44
> : KCModule(parent, args)//DeviceAutomounterKCMFactory::componentData(),
> parent)
> + , m_devices(new DeviceModel(this))
> {
This is wrongly indented
> ervin wrote in DeviceAutomounterKCM.cpp:114
> I'd store the result of the automountEnabled call in an intermediate
> variable, just to make things more readable.
Comment has been marked done but I don't see it changed here. Wrong status of
the review?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27127
To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
