ervin added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounterKCM.cpp:57
> Please beware this will make my patch quite a lot more intrusive, DeviceModel 
> for instance, will need a field to keep some reference to the 
> AutomounterSettings

Sure, moving away from a singleton is always intrusive (just like moving away 
from a global variable which it is really). Let's aim for it in a different 
specific patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to