> On 2010-03-18 10:56:47, Sebastian Kügler wrote: > > > > Sebastian Kügler wrote: > Looks good from my POV, I'd like Aaron to have a look over this as well > though. If he's OK with it, ship it :)
i think it's an interesting solution to the problem; it's not in the "right" place (it should be passed into the ctor with the args list as part of the routine in Applet::load) and it doesn't actually address the issue of being able to package addons nicely (but that's ignorable for this particular case, i suppose). *thinks* well, let's do this: let's try the patch as-is as an experiment and see how well it works out. if it proves to be a good approach then we can generalize it later into libplasma (e.g. by putting the reading of the value into Applet::load) - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3315/#review4549 ----------------------------------------------------------- On 2010-03-18 12:21:54, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3315/ > ----------------------------------------------------------- > > (Updated 2010-03-18 12:21:54) > > > Review request for Plasma. > > > Summary > ------- > > Load webslice params from desktop file so webslices can be shared in > kde-look.org as plasmoid packages (package containing only a custom desktop > file). > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/webslice/kgraphicswebslice.cpp 1104337 > > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/plasma-applet-webslice.desktop > 1104337 > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/webslice.cpp 1104337 > > Diff: http://reviewboard.kde.org/r/3315/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
