----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3315/#review4549 -----------------------------------------------------------
/trunk/KDE/kdeplasma-addons/applets/webslice/plasma/webslice.cpp <http://reviewboard.kde.org/r/3315/#comment3997> Maybe add some feedback when at least the number of arguments doesn't match, or the first argument is not a valid URL? (I imagine people trying to add webslices, but failing to find out what's wrong with their configs) /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/webslice.cpp <http://reviewboard.kde.org/r/3315/#comment3996> Why? We should still be able to configure the applet in this case, no? (I'm actually not 100% sure about it, but would be interested in your reasoning.) - Sebastian On 2010-03-18 10:11:49, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3315/ > ----------------------------------------------------------- > > (Updated 2010-03-18 10:11:49) > > > Review request for Plasma. > > > Summary > ------- > > Load webslice params from desktop file so webslices can be shared in > kde-look.org as plasmoid packages (package containing only a custom desktop > file). > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/webslice/kgraphicswebslice.cpp 1104337 > > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/plasma-applet-webslice.desktop > 1104337 > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/webslice.cpp 1104337 > > Diff: http://reviewboard.kde.org/r/3315/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
