On Sat, Jun 13, 2009 at 2:32 AM, Aaron J. Seigo<ase...@kde.org> wrote: > On Friday 12 June 2009, Akmanalp, Mehmet A wrote: >> >> * mark all the methods currently in Animator as KDE_DEPRECATED >> >> Did so. I also marked the enums and the AnimatorPrivate deprecated >> too, and added @deprecated s to the comments. It compiles and runs >> fine afaik. Have I missed anything? (Changes in attachment) > > oops, spoke too soon. just noticed self() is marked as deprecated, and it > shouldn't be. Animator will still be a singleton. > > timerEvent doesn't need to be marked as deprecated either, it's a > reimplementation of timerEvent from QObject. > > the private slots don't need to be marked as deprecated either, as they are > private API :)
Hah, it seems i went into a copy-paste frenzy. I'll fix those. Yeah, I made a branch under branches/work/~makmanalp/. I just wanted to make sure I wasn't doing silly stuff since I never worked with KDE_DEPRECATED before :) -- ~ mali (http://constant.inople.net/) _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
