On Fri, Jun 12, 2009 at 5:29 PM, Aaron J. Seigo <ase...@kde.org> wrote:
> On Friday 12 June 2009, Alexis Ménard wrote: > > On Fri, Jun 12, 2009 at 3:40 PM, Akmanalp, Mehmet A > <makman...@wpi.edu>wrote: > > > > 1) Move the old animator.cpp into deprecated/ and create a whole new > > > animator.cpp with a whole new Plasma::Animator? If so, how is this > > > "extend Plasma::Animator"? > > > > Yes move it just. And create a new class for now. > > > > > 2) Move the old animator.cpp into deprecated/ and extend it in the new > > > animator.cpp? Then, this doesn't solve the naming issue(We still have > > > to use a different name, not "Animator"), and it isn't "retro-fitting > > > Animation". > > > > You can't remove it completly, symbols have to be here for binary > > compatibilty reasons. > > Grab a name (can't be Animator), the one you want, we will see later. > > erf.. i'm concerned we're going to confuse Mehmet with conflicting advice > ... > but here goes anyways ;) > > my thoughts are this: > > Animator is a great name and says what it does; i don't want two classes > kicking around, and we can't remove Animator. soooo: > > * mark all the methods currently in Animator as KDE_DEPRECATED > Didn't know that... > > * add the new methods for the kinetic project to animator.h > Yep. > > * move the current animator.cpp into deprecate > > * create a new .cpp file for the new implementation: > kdelibs/plasma/animator.cpp > > * move the constructor and destructor from plasma/deprecated/animator.cpp > into > the new plasma/animator.cpp, as it needs to join the new implementation. > > this means that the deprecated implementation is in > plasma/deprecated/animator.cpp, the new stuff is in plasma/animator.cpp and > we > keep Animator around as a class that people use for the kinetic stuff. > > Alexis: does that make sense to you as well? :) Then it makes sense. > > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Software > > > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
