https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #195 from Nicola Taibi <[email protected]> --- Subject: Update regarding faction identification logic in spacegl_diag Hi, I am writing to provide context regarding the recent changes to the spacegl_diag diagnostic tool. It has come to our attention that the telemetry output for players was incorrectly defaulting to "Alliance" in the spacegl_diag view, regardless of the captain's actual faction affiliation. This was due to a hardcoded string assignment within the player information display logic (case 0 in src/spacegl_diag.c). To rectify this, I have updated the logic to dynamically retrieve the faction name using the get_species_name(p->faction) function. This ensures that the diagnostic interface accurately reflects the captain's chosen faction, thereby maintaining consistent data reporting across all telemetry modules. Thank you for your time and for reviewing these changes. Best regards, Nicola Taibi Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10354682-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10354682-spacegl/spacegl-2026.04.22.01-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c195 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
