https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #193 from Nicola Taibi <[email protected]> --- (In reply to Fabio Porcedda from comment #192) > Hi, > 1) > as stated in > https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ the spec > should be like this: > > %conf > %cmake > > %build > %cmake_build > > instead of: > %build > %cmake \ > -DCMAKE_BUILD_TYPE=RelWithDebInfo \ > -DCMAKE_STRIP=/bin/true > > %cmake_build > > > because executables should not be forced stripped and the correct > configuration is already choosen by the %cmake macro. > > 2) > Please dont' duplicate the README files. > Use %doc for readme_assets and put then in the same package and folder as > README files. > > 3) > Please use english in all comments. > > Regards > Fabio Subject: Compliance Update for Space GL Package - Fedora Packaging Guidelines HI, Thank you for your valuable feedback regarding the Space GL package. I have implemented the requested adjustments to align the package with the Fedora Packaging Guidelines. Please find below a summary of the actions taken: 1. CMake Packaging Compliance: Updated spacegl.spec to use the standardized %cmake and %cmake_build macros as per the Fedora CMake Packaging Guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/). I have removed all manual build configuration flags and the directive to strip binaries, ensuring the build process conforms to Fedora standards. 2. Documentation Consolidation: Removed the redundant copies of documentation files within the assets folders. The package now correctly utilizes the %doc directive in the spec file to include the primary README files and the consolidated readme_assets/ directory, streamlining the installation footprint. 3. Standardization of Comments: Performed a comprehensive review of all source files (.c, .h, .sh). All technical comments have been translated from Italian to English to ensure a unified and professional codebase. The package has been verified to build successfully, and I have confirmed that all documentation and source code are now fully localized in English. Thank you for your guidance in improving the quality and compliance of this package. Please let me know if any further adjustments are required. Best regards, Nicola Taibi Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10353459-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10353459-spacegl/spacegl-2026.04.21.01-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c193 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
