https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #192 from Fabio Porcedda <[email protected]> --- Hi, 1) as stated in https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ the spec should be like this: %conf %cmake %build %cmake_build instead of: %build %cmake \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_STRIP=/bin/true %cmake_build because executables should not be forced stripped and the correct configuration is already choosen by the %cmake macro. 2) Please dont' duplicate the README files. Use %doc for readme_assets and put then in the same package and folder as README files. 3) Please use english in all comments. Regards Fabio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c192 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
