https://bugzilla.redhat.com/show_bug.cgi?id=2442188

Daniel BerrangĂ© <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #11 from Daniel BerrangĂ© <[email protected]> ---
> Release:        1%{?dist}

I'd suggest  %autorelease


> %global _description %{expand:
> systemd services for AWS Nitro Enclaves.}
>
> %description %{_description}

What's the purpose of this macro when it is only used once ?

> %{_unitdir}/nitro-enclaves-allocator.service

I think you'll also want a  "%dir %{_unitdir}" so you (co-)own the dir, as
there's no systemd dependency that guarantees ownership

> %{_sysconfdir}/nitro_enclaves

Needs to be marked %dir

> %{_sysconfdir}/nitro_enclaves/allocator.yaml

Needs to be marked %config


> %changelog
> * Fri Feb 20 2026 Tyler Fanelli <[email protected]> - 0.1.0-1
> - Initial version for Fedora review.

I'd suggest %autochangelog


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2442188

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202442188%23c11

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to