https://bugzilla.redhat.com/show_bug.cgi?id=2442188
Daniel Berrangé <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #18 from Daniel Berrangé <[email protected]> --- > %bcond check 1 Unused, remove it > %build > # nothing Pointless, just remove it A few small points for upstream In the unit file > StandardOutput=journal > StandardError=journal > SyslogIdentifier=nitro-enclaves-allocator The syslog name is just hardcoding what is already the default, so that appears pointless. The StandardOutput/Error settings are force overriding the sysadmin's preference from /etc/systemd/system.conf. I don't see a compelling reason to not honour the systemd admin decided defaults. IOW, all three lines should be removed IMHO. The nitro-enclaves-allocator script has no stated license. It ought to have a SPDX-License-Identifier tag added. None of these are review blockers => approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2442188 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202442188%23c18 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
