https://bugzilla.redhat.com/show_bug.cgi?id=2442188
--- Comment #6 from Tyler Fanelli <[email protected]> --- (In reply to Ben Beasley from comment #4) > At a quick preliminary glance: > > It seems like, rather than "%global debug_package %{nil}", it would be > better to make this a noarch package ("BuildArch: noarch"). > > If I understand correctly, the nitro-enclaves-allocator script is only > intended for use via the systemd service, not for direct use by humans. In > this case, it would be better installed in %{_libexecdir} instead of > %{_bindir}. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_libexecdir. The > ExecStart entry in the service file would have to be adjusted accordingly; > this could be a downstream-only patch, if you like. > > You don’t need to number "Source0:"; you can just write "Source:" if you > like. > > There is a typo in "${url}/archive/refs/tags/v%{version}.tar.gz". The > initial "$" should be a "%". Thanks, I've made the relevant changes and resubmitted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2442188 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202442188%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
