On Thu, 26 Mar 2026 16:33:55 GMT, Andy Goryachev <[email protected]> wrote:
>>> There are plans to change the caret shape for certain BIDI/RTL scenarios to >>> indicate the direction, so the old assumptions might not hold anymore. >> >> When that happens, this code of course need to be adjusted. But they will >> probably require more code changes. >> In any case, the empty `else if` block does not make sense > > This is an area of constant disagreement: I think it's ok to have minor > cleanup like this one here, while @kevinrushforth much prefers to keep the PR > focused on the fix and create a separate follow-up tickets when required, the > rationale being backporting and merge conflicts. Piling up unrelated changes > also delays the fix. I think the newest version looks very good and should still be easy to e.g. backport. And is now more clear, with variables that express the purpose (which makes comments obsolete, good!). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2128#discussion_r3015200222
