On Thu, 26 Mar 2026 16:24:19 GMT, Marius Hanl <[email protected]> wrote:
>> I think it's out of scope for this PR, for several reasons. >> >> This code relies on current, undocumented behavior of the caret shape being >> either a single line or two lines encoded as `MoveTo`-`LineTo` pairs. There >> are plans to change the caret shape for certain BIDI/RTL scenarios to >> indicate the direction, so the old assumptions might not hold anymore. >> >> Also, in jfx25 we've added `LayoutInfo`/`CaretInfo` APIs in the `Text` and >> `TextFlow`, which should provide the caret information without relying on >> implementation details. >> >> related umbrellas: >> https://bugs.openjdk.org/browse/JDK-8343557 >> https://bugs.openjdk.org/browse/JDK-8300569 > >> There are plans to change the caret shape for certain BIDI/RTL scenarios to >> indicate the direction, so the old assumptions might not hold anymore. > > When that happens, this code of course need to be adjusted. But they will > probably require more code changes. > In any case, the empty `else if` block does not make sense This is an area of constant disagreement: I think it's ok to have minor cleanup like this one here, while @kevinrushforth much prefers to keep the PR focused on the fix and create a separate follow-up tickets when required, the rationale being backporting and merge conflicts. Piling up unrelated changes also delays the fix. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2128#discussion_r2996235055
