On Wed, 25 Mar 2026 18:40:26 GMT, Marius Hanl <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Adjust tests
>> - Adjust tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
> line 259:
>
>> 257: // The caret is split. Ignore and keep the previous
>> width value.
>> 258: } else {
>> 259: caretWidth =
>> Math.round(caretPath.getLayoutBounds().getWidth());
>
> I'm confused, isn't this effectively dead code?
>
> `if (!4) { .. } elseif (4) { .. } else { when do we come here? }`
Yes, it was. But it shouldn't have been
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2128#discussion_r2990282501
