On Sun, 29 Mar 2026 19:56:10 GMT, Philemon Hilscher <[email protected]> wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/CellBehaviorBase.java
>> line 167:
>>
>>> 165:
>>> 166: protected int getIndex() {
>>> 167: return getNode() != null ? getNode().getIndex() : -1;
>>
>> Can `getNode()` return null?
>
> unsure, but the instanceof check also covered this.
I would remove it, because `getNode()` is called often without any null check,
so it does not makes sense that it is only done here.
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TreeTableRowBehavior.java
>> line 56:
>>
>>> 54:
>>> 55: /** {@inheritDoc} */
>>> 56: @Override protected int getItemCount() {
>>
>> `@Override` should be above the method
>
> I agree, but this introduces a different code style for this class. I would
> postpone this to a ticket that cleans up formatting issues.
Sure. But it is also fine if you 'break' it, as we did that several times in
the past.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r3009214457
PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r3009209829
