> This fixes the issue adressed here https://bugs.openjdk.org/browse/JDK-8222454 > > The added TreeTableViewTests were failing without the main code changes. I > added the other tests to ensure the consistent functionality of related cell > based components. > The method getItemCount() needed to be moved to CellBehaviorBase to do the > necessary index check in doSelect() below. All subclasses now implement this > method based on the cell container. > > There is still some refactoring potential here, to reduce code duplications > and ensure consistent behavior of all cell based components. This could be > done in a follow-up PR.
Philemon Hilscher has updated the pull request incrementally with one additional commit since the last revision: 8222454: Review fixes Signed-off-by: Philemon Hilscher <[email protected]> ------------- Changes: - all: https://git.openjdk.org/jfx/pull/2129/files - new: https://git.openjdk.org/jfx/pull/2129/files/39477ef1..28d95b6f Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=2129&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2129&range=00-01 Stats: 21 lines in 3 files changed: 14 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jfx/pull/2129.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2129/head:pull/2129 PR: https://git.openjdk.org/jfx/pull/2129
