On Sat, 28 Mar 2026 14:37:40 GMT, Marius Hanl <[email protected]> wrote:
>> This fixes the issue adressed here >> https://bugs.openjdk.org/browse/JDK-8222454 >> >> The added TreeTableViewTests were failing without the main code changes. I >> added the other tests to ensure the consistent functionality of related cell >> based components. >> The method getItemCount() needed to be moved to CellBehaviorBase to do the >> necessary index check in doSelect() below. All subclasses now implement this >> method based on the cell container. >> >> There is still some refactoring potential here, to reduce code duplications >> and ensure consistent behavior of all cell based components. This could be >> done in a follow-up PR. > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TreeTableRowBehavior.java > line 56: > >> 54: >> 55: /** {@inheritDoc} */ >> 56: @Override protected int getItemCount() { > > `@Override` should be above the method I agree, but this introduces a different code style for this class. I would postpone this to a ticket that cleans up formatting issues. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r3006646963
