jjtt commented on code in PR #2230:
URL: https://github.com/apache/zookeeper/pull/2230#discussion_r1995026003
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java:
##########
@@ -1490,7 +1490,7 @@ public String create(
final String serverPath = prependChroot(clientPath);
RequestHeader h = new RequestHeader();
- setCreateHeader(createMode, h);
+ setCreateHeader(createMode, h, stat != null);
Create2Response response = new Create2Response();
Review Comment:
Yes, there are test failures (I was lazy and hoping the CI would run the
tests)
For example `org.apache.zookeeper.test.CreateTest#testCreateWithNullStat` is
failing with a null value in
`org.apache.zookeeper.proto.Create2Response#deserialize`.
More precisely it's a null stat that is being deserialized?
`org.apache.zookeeper.data.Stat#deserialize`
Is this something like the server is sending a `CreateResponse` and the
client is trying to parse it as a `Create2Response`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
