kezhuw commented on code in PR #2230:
URL: https://github.com/apache/zookeeper/pull/2230#discussion_r1990526981
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java:
##########
@@ -1490,7 +1490,7 @@ public String create(
final String serverPath = prependChroot(clientPath);
RequestHeader h = new RequestHeader();
- setCreateHeader(createMode, h);
+ setCreateHeader(createMode, h, stat != null);
Create2Response response = new Create2Response();
Review Comment:
`Create2Response` has one more field `stat` comparing to `CreateResponse`,
so I expected there are test failures.
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java:
##########
@@ -1503,11 +1503,19 @@ public String create(
return chroot.strip(response.getPath());
}
- private void setCreateHeader(CreateMode createMode, RequestHeader h) {
+ private void setCreateHeader(CreateMode createMode, RequestHeader h,
boolean requestStat) {
if (createMode.isTTL()) {
h.setType(ZooDefs.OpCode.createTTL);
} else {
- h.setType(createMode.isContainer() ?
ZooDefs.OpCode.createContainer : ZooDefs.OpCode.create2);
+ if (createMode.isContainer()) {
Review Comment:
I think it is better to flatten these `if-else` to one level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
