jjtt commented on code in PR #2230:
URL: https://github.com/apache/zookeeper/pull/2230#discussion_r1994990731
##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java:
##########
@@ -1503,11 +1503,19 @@ public String create(
return chroot.strip(response.getPath());
}
- private void setCreateHeader(CreateMode createMode, RequestHeader h) {
+ private void setCreateHeader(CreateMode createMode, RequestHeader h,
boolean requestStat) {
if (createMode.isTTL()) {
h.setType(ZooDefs.OpCode.createTTL);
} else {
- h.setType(createMode.isContainer() ?
ZooDefs.OpCode.createContainer : ZooDefs.OpCode.create2);
+ if (createMode.isContainer()) {
Review Comment:
That is an excellent point. Made a fixup commit:
5065b64b60478e0eac57478218ad3f870b3e64ed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
