slachiewicz commented on PR #3778: URL: https://github.com/apache/thrift/pull/3778#issuecomment-5506337587
On the two-representation point: Go has no hashable form for a list, set or map key, so the only single representation would be to emit every map as an entry slice, which changes the type of every existing generated field. The per-key-type split keeps generated code for today's IDLs byte-identical and is confined to one predicate in the generator. There is precedent for the Go representation following what Go can express rather than the Thrift kind: `set` has always generated as a slice while `map` generates as a map. If a uniform slice representation is wanted later, it fits as a generator option layered on the same entry type without changing this default. Happy to go either way if you and @dcelasun prefer the option now. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
