fishy commented on PR #3778: URL: https://github.com/apache/thrift/pull/3778#issuecomment-5502579577
looks good to me besides the `is_map_entry_slice` name. although I'm not sure splitting the generated map types is going to be a good idea longer term. cc @dcelasun for second opinion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
