Copilot commented on code in PR #3778: URL: https://github.com/apache/thrift/pull/3778#discussion_r3909488224
########## lib/go/thrift/map_entry.go: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package thrift + +// MapEntry is one key/value pair of a Thrift map whose key type cannot be a +// Go map key: list, set and map keys, and typedefs resolving to one of those. +// +// The generator represents such a field as []MapEntry[K, V]. Entries are +// written to the wire in slice order. Uniqueness of keys is not enforced on +// read or write, which mirrors how this library represents Thrift sets as +// slices. Review Comment: The MapEntry doc comment says key uniqueness is not enforced on read or write, but the Go generator emits an INVALID_DATA protocol exception when writing a container-keyed map with duplicate keys (and the README/tests reflect that behavior). The comment should be updated to match the actual semantics so users aren't surprised by serialization failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
