cameron-martin commented on PR #3083: URL: https://github.com/apache/thrift/pull/3083#issuecomment-2592455608
> We tried to use this PR's changes to build our own service, and when looking inside the generated files, we noticed that the import statements are like this: Does this happen when a thrift file includes another thrift file? I don't think this is something the tests are covering atm. I'll investigate and add a test for it. > We had some issues when integrating the nodejs thrift build into our project, so we thought it would be nice if we could decouple the esm build from the nodejs dependencies. And of course, supporting native esm browser packages would be beneficial too :D However, it is good to know that the nodejs version worked for you - I will take another look and check if we are missing anything in our project's build tool! It worked for us by polyfilling a few NodeJS dependencies (such as `util`, `Buffer`, etc), but I've been wanting to remove the dependencies on these since in modern JS environments there are cross-runtime alternatives. See [THRIFT-5844](https://issues.apache.org/jira/browse/THRIFT-5844). In fact we have a few PRs in the works that should remove these. Another part that is missing is browser tests for the NodeJS package, but I also have plans to contribute these too. This does call into question the necessity of a separate nodejs and js package. Does anyone do web development without a bundler currently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
