cameron-martin commented on PR #3083: URL: https://github.com/apache/thrift/pull/3083#issuecomment-2693779955
It looks like this is a conflict between https://github.com/apache/thrift/pull/3087 and https://github.com/apache/thrift/pull/3089. The issue here is that upgrading eslint updated `@types/estree`, and this package uses features of the typescript standard library (introduced in [3.2](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html#bigint) and [3.5](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-5.html#the-omit-helper-type)) that aren't in the version that we use. My suggested fix here would be to upgrade typescript to a newer version. I already have a PR up for this (https://github.com/apache/thrift/pull/3084). This PR upgrades it to the latest version. However, I see that typescript version is in the [language support document](https://github.com/apache/thrift/blob/master/LANGUAGES.md), so do we want to upgrade this to the latest or just a slightly newer version, to unsure that we support older versions too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
