cameron-martin commented on PR #3083:
URL: https://github.com/apache/thrift/pull/3083#issuecomment-2589409131

   > Thanks for this, we were actually planning to add something similar but 
for the browser. We can make a follow up PR to add support for esm on the 
browser side as well.
   
   That's interesting, because this is our exact use case, but we use the 
nodejs package in the browser. Is your plan here to support es modules that can 
directly execute in the browser, with no build tools at all?
   
   > While testing this locally we noticed import statements are not changed to 
the esm format.
   
   I must have missed this, I'll push an update. It also will need syncing with 
the nodejs CI changes (#3082).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to