fishy commented on code in PR #3018: URL: https://github.com/apache/thrift/pull/3018#discussion_r1717205094
########## LANGUAGES.md: ########## @@ -163,9 +163,9 @@ Thrift's core protocol is TBinary, supported by all languages except for JavaScr <td align=left><a href="https://github.com/apache/thrift/blob/master/lib/go/README.md";>Go</a></td> <!-- Since -----------------><td>0.7.0</td> <!-- Build Systems ---------><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td> -<!-- Language Levels -------><td>1.21</td><td>1.22</td> +<!-- Language Levels -------><td>1.22</td><td>1.23</td> <!-- Field types -----------><td><img src="/doc/images/cgrn.png" alt="Yes"/></td> -<!-- Low-Level Transports --><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td> +<!-- Low-Level Transports --><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td> Review Comment: go has support for unix domain socket for a while now, fixed the language matrix entry for this here. ########## test/go/src/common/clientserver_test.go: ########## @@ -34,18 +35,17 @@ import ( type test_unit struct { host string - port int64 Review Comment: this is an improvement on the tests to always use port 0 and let listener to pick an available port for us (except for http context timeout test) ########## lib/go/thrift/ssl_server_socket.go: ########## @@ -93,6 +93,9 @@ func (p *TSSLServerSocket) Open() error { } func (p *TSSLServerSocket) Addr() net.Addr { + if p.listener != nil { + return p.listener.Addr() + } Review Comment: this is a bug that it could return the wrong address (for example when constructed with port 0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
