emmenlau commented on code in PR #3002: URL: https://github.com/apache/thrift/pull/3002#discussion_r1707155183
########## lib/cpp/src/thrift/TUuid.h: ########## @@ -17,6 +17,9 @@ * under the License. */ +#pragma once Review Comment: Currently thrift guards `#pragma once` with the following construct: ``` #if defined(_MSC_VER) && (_MSC_VER > 1200) #pragma once #endif // _MSC_VER ``` Could you kindly apply the same here, or are there reasons not to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
