fishy commented on code in PR #3018:
URL: https://github.com/apache/thrift/pull/3018#discussion_r1717242454
##########
test/go/src/common/clientserver_test.go:
##########
@@ -42,10 +43,10 @@ type test_unit struct {
}
var units = []test_unit{
- {"127.0.0.1", 9095, "", "", "binary", false},
- {"127.0.0.1", 9091, "", "", "compact", false},
- {"127.0.0.1", 9092, "", "", "binary", true},
- {"127.0.0.1", 9093, "", "", "compact", true},
+ {"127.0.0.1", 0, "", "", "binary", false},
+ {"127.0.0.1", 0, "", "", "compact", false},
+ {"127.0.0.1", 0, "", "", "binary", true},
+ {"127.0.0.1", 0, "", "", "compact", true},
Review Comment:
this is an improvement on the tests to always use port 0 and let listener to
pick an available port for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
