Xiao-zhen-Liu commented on code in PR #4342:
URL: https://github.com/apache/texera/pull/4342#discussion_r3041095204
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/metadata/OperatorMetadataGenerator.scala:
##########
@@ -37,8 +38,8 @@ case class OperatorInfo(
userFriendlyName: String,
operatorDescription: String,
operatorGroupName: String,
- inputPorts: List[InputPort],
Review Comment:
Why is this defaulted to be `disallow`?
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/metadata/OperatorMetadataGenerator.scala:
##########
@@ -37,8 +38,8 @@ case class OperatorInfo(
userFriendlyName: String,
operatorDescription: String,
operatorGroupName: String,
- inputPorts: List[InputPort],
- outputPorts: List[OutputPort],
Review Comment:
Why is this change added?
##########
frontend/src/app/workspace/service/operator-metadata/mock-operator-metadata.data.ts:
##########
@@ -264,7 +264,7 @@ export const mockUnionSchema: OperatorSchema = {
userFriendlyName: "Union",
operatorDescription: "Union multiple inputs",
operatorGroupName: "Analysis",
- inputPorts: [{ allowMultiLinks: true }],
+ inputPorts: [{ disallowMultiLinks: true }],
Review Comment:
I thought this is going to be false by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
