aglinxinyuan commented on issue #4329: URL: https://github.com/apache/texera/issues/4329#issuecomment-4157657172
I don't want to keep this flag in the codebase. First, it’s neither user-facing nor configurable, so it doesn’t directly impact the user experience. Keeping it for that reason doesn’t seem justified. Second, we don’t have a corresponding flag for output ports, and I’d prefer we keep the system consistent. While input and output ports aren’t semantically symmetric, aligning their design and user experience is still important. Finally, retaining an unused flag and the associated code is generally a bad practice. In our current code base, this flag is used to support operators with different behaviors: some allowed multi-links when the flag was enabled, while most disallowed them by default. In the proposed design, however, all operators support multi-links. Unless we identify a concrete case where an operator should explicitly disallow multi-links, this flag becomes effectively unused and turns into dead code. We’ve seen similar cases in the past where such flags lingered without real usage. I’d prefer to avoid repeating that pattern. That said, I’m open to keeping the flag if we can point to a real use case—i.e., a specific operator that should not allow multi-links. Otherwise, I think we should remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
