alveifbklsiu259 commented on PR #32333: URL: https://github.com/apache/superset/pull/32333#issuecomment-2676002364
@rusackas > Also, regarding the type checking from the prior PR, I noticed that running pre-commit run --all-files is super slow and resource intensive. npm run type is MUCH faster. Do you think there's anything that can be improved on that front? The resource-intensive issue of running `pre-commit type-checking-frontend --all-files` should be fixed after the merge of [32323](https://github.com/apache/superset/pull/32323). Simply put, by default each pre-commit hook runs in parallel with a different set of files. This means that when you run `--all-files`, the hook `type-checking-frontend` runs the corresponding script 16 times(according to my test), causing `tsc` to run 16 times. This is solved by running the hook sequentially. As for the execution time compared to `npm run type`, running `pre-commit type-checking-frontend --all-files` takes almost twice the amount of time because of command line length limits, it's not feasible to pass all files to a single command invocation. Instead, pre-commit splits the files into manageable chunks and processes them. (2 chunks according to my test) A more detailed explanation can be found in [32323](https://github.com/apache/superset/pull/32323). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
