rusackas commented on PR #32333: URL: https://github.com/apache/superset/pull/32333#issuecomment-2675299939
Do we need the extra script file here, or does simply removing the `sed` business and letting the pre-commit hook run `npm run lint` (or even `npm run lint-fix`) from the pre-commit config do the job? I'm just hoping to reduce complexity/maintenance if it's not needed. Also, regarding the type checking from the prior PR, I noticed that running `pre-commit run --all-files` is super slow and resource intensive. `npm run type` is MUCH faster. Do you think there's anything that can be improved on that front? Appreciating the help here, by the way! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
